First ever script, All it does is swap Item and save around! Options

[kaimonkey]

Yeah, Im not sure if I should post here because my script will not be used, but I just want to say that I have made my first script, and will now begin to wander through the requests untill I find somthing easy, but any way, here's my swaps save and item round script- post above main as always!

[Show/Hide] swap save and item in menu

CODE

class Scene_Menu < Scene_Base
  def create_command_window
    s1 = Vocab::save
    s2 = Vocab::skill
    s3 = Vocab::equip
    s4 = Vocab::status
    s5 = Vocab::item
    s6 = Vocab::game_end
    @command_window = Window_Command.new(160, [s1, s2, s3, s4, s5, s6])
    @command_window.index = @menu_index
    if $game_party.members.size == 0          # If number of party members is 0
      @command_window.draw_item(0, false)     # Disable item
      @command_window.draw_item(1, false)     # Disable skill
      @command_window.draw_item(2, false)     # Disable equipment
      @command_window.draw_item(3, false)     # Disable status
    end
    if $game_system.save_disabled             # If save is forbidden
      @command_window.draw_item(4, false)     # Disable save
    end
  end

  def update_command_selection
    if Input.trigger?(Input::B)
      Sound.play_cancel
      $scene = Scene_Map.new
    elsif Input.trigger?(Input::C)
      if $game_party.members.size == 0 and @command_window.index < 4
        Sound.play_buzzer
        return
      elsif $game_system.save_disabled and @command_window.index == 4
        Sound.play_buzzer
        return
      end
      Sound.play_decision
      case @command_window.index
          when 0      # Save
        $scene = Scene_File.new(true, false, false)
      when 1,2,3  # Skill, equipment, status
        start_actor_selection
    when 4      # Item
        $scene = Scene_Item.new
      when 5      # End Game
        $scene = Scene_End.new
      end
    end
  end
end

#------------#
# Edit items #
#------------#
class Scene_Item < Scene_Base
  def return_scene
    $scene = Scene_Menu.new(4)
  end
end
class Scene_File < Scene_Base
   def return_scene
    if @from_title
      $scene = Scene_Title.new
    elsif @from_event
      $scene = Scene_Map.new
    else
      $scene = Scene_Menu.new(0)
    end
  end  
end

If there is anything I have done wrong/could do better, please tell me as I did this purely to learn!

This post has been edited by kaimonkey: Jan 22 2009, 01:12 AM

[BigEd781]

Nothing wrong there really. All of the methods that you overrode had to be, they couldn't be aliased to do what you wanted. I would recommend that you list case statements in numerical order for readability, i.e.,

CODE

case @command_window.index
  when 0      # Save
    $scene = Scene_File.new(true, false, false)
  when 1,2,3  # Skill, equipment, status
    start_actor_selection
  when 4      # Item
    $scene = Scene_Item.new  
  when 5      # End Game
    $scene = Scene_End.new
end

Good job on your first script

[kaimonkey]

Ok, Ive changed that, is it good now?!?

[BigEd781]

Looks fine to me. I would recommend making something new now instead of editing existing scripts if you feel up to it.

[SojaBird]

Well sure it's going the right way.
Though as you say, you could go check the requests.
You'll find something suitable, I'm sure

Good job.


Greatzz,
SojaBird.