ACS 2 Issue Options

[Aedales]

Ok.. I'm new to RPG MakerVX and have been flawlessly (with a few minor bumps I figured out on the way) able to insert scripts. Here are the current scripts I have:




When adding in the ACS script which can be found here:
ACS Script

I first got an error because of my menu system. I followed the instructions and turned off the menu addition then set up an npc to run the crafting with: $scene = Scene_Crafting.new

I also went in and made sure to copy every single item, weapon, and armor from the demo to their exact numbers in my database. I also got Jets recipe editor from: Jets ACS Recipe Editor

I double checked all of my recipes and items. Double checked that I had my recipies.txt file in data. Now when I click on the NPC for crafting I get the following error then the game crashes:



I have sat here for 2 hours and have not been able to figure this out. Here is a copy of the actual Window_Crafting_Recipes script:

CODE

class Window_Crafting_Recipes < Window_Selectable
  
  attr_reader :results_window
  attr_reader :status_window
  attr_reader :detail_window
  attr_accessor :refreshNeeded
  
  def initialize(x, y, width, height)
    super(x, y, width, height)
    self.index = 0
    
    #---------------------------------------------------------------------------
    # Icon indexes for the show/hide toggle for recipe categories
    #---------------------------------------------------------------------------
    @showIcon = 1807
    @hideIcon = 1806
    
    #---------------------------------------------------------------------------
    # Change this to false if you do not wish for the game to remember
    # whether a category was shown or hidden the last time the player used the
    # crafting interface
    #---------------------------------------------------------------------------
    @rememberCategoryStates = false
    
    #---------------------------------------------------------------------------
    # If you do not want to remember category states, then a default state is
    # chosen when the crafting menu is launched. Change this to true if you wish
    # to launch the menu with categories expanded.
    #---------------------------------------------------------------------------
    @defaultShowState = false
    
    #---------------------------------------------------------------------------
    # Change this to false if you would like to disable sorting by category
    #---------------------------------------------------------------------------
    @usingCategories = false
    
    initCategories if @usingCategories
    
    if @usingCategories
      categoryRefresh
    else
      refresh
    end
  end
  
  def initCategories
    @categoryNames    = $game_crafting.categoryLabels
    @categoryText     = $game_crafting.categoryText
    @categoryIndices  = []
    @showCategory     = []
    if @rememberCategoryStates
      @showCategory = $game_crafting.categoryStates
    else
      for x in 0..@categoryNames.length - 1
        @showCategory.push(@defaultShowState)
      end
    end
  end
  
  def update
    super
    updateIngredients
    updateStatus
    updateDetails
    update_help
    if @refreshNeeded
      if @usingCategories
        categoryRefresh
      else
        refresh
      end
    end
  end
  
  def categoryRefresh
    self.contents.clear
    @data = []
    @categoryIndices = []
    index = 0
    
    for x in 0..@categoryNames.length - 1
      @categoryIndices.push(index)
      @data.push(nil)
      index += 1
      if @showCategory[x]
        for recipe in $game_crafting.recipeList
          if recipe.isDiscovered? and recipe.category == x
            @data.push(recipe)
            index += 1
          end
        end
      end
    end
    
    @item_max = @data.size
    create_contents
    for i in 0...@item_max
      if @categoryIndices.index(i) != nil
        draw_category(i)
      else
        draw_recipe(i)
      end
    end
    
    @refreshNeeded = false
  end
  
  def refresh
    self.contents.clear
    @data = []
    for recipe in $game_crafting.recipeList
      @data.push(recipe) if recipe.isDiscovered?
    end
    @item_max = @data.size
    create_contents
    for i in 0...@item_max
      draw_recipe(i)
    end
    @refreshNeeded = false
  end
  
  def draw_category(index)
    rect = item_rect(index)
    self.contents.clear_rect(rect)
    categoryIndex = @categoryIndices.index(index)
    categoryName = @categoryNames[categoryIndex]
    icon = @showCategory[categoryIndex] ? @showIcon : @hideIcon
    if categoryName != nil
      rect.width -= 4
      draw_icon(icon, rect.x, rect.y, true)
      self.contents.font.color = normal_color
      self.contents.draw_text(rect.x + 24, rect.y, 172, WLH, categoryName)
    end
  end
  
  def draw_recipe(index)
    rect = item_rect(index)
    self.contents.clear_rect(rect)
    recipe = @data[index]
    if recipe != nil
      enabled = recipe.isCraftable?
      rect.width -= 4
      draw_recipe_name(recipe, rect.x + 24, rect.y, enabled)
    end
  end
  
  def draw_recipe_name(recipe, x, y, enabled = true)
    if recipe != nil
      draw_icon(recipe.icon_index, x, y, enabled)
      self.contents.font.color = normal_color
      self.contents.font.color.alpha = enabled ? 255 : 128
      self.contents.draw_text(x + 24, y, 172, WLH, recipe.name)
    end
  end
  
  def recipe
    return @data[self.index]
  end
  
  def isCategory?
    return false if @categoryIndices.index(self.index) == nil
    return true
  end
  
  def toggleCategory
    if @showCategory[@categoryIndices.index(self.index)]
      @showCategory[@categoryIndices.index(self.index)] = false
    else
      @showCategory[@categoryIndices.index(self.index)] = true
    end
  end
  
  def ingredients_window=(ingredients_window)
    @ingredients_window = ingredients_window
    updateIngredients
  end
  
  def status_window=(status_window)
    @status_window = status_window
    updateStatus
  end
  
  def detail_window=(detail_window)
    @detail_window = detail_window
    updateDetails
  end
  
  def updateIngredients
    if recipe == nil
      @ingredients_window.set_tools(@categoryIndices.index(self.index))
    else
      @ingredients_window.set_ingredients(recipe)
    end
  end
  
  def updateStatus
    @status_window.set_status(recipe)
  end
  
  def updateDetails
    @detail_window.set_details(recipe)
  end
  
  #-----------------------------------------------------------------------------
  # Updates the help window with the text of the description of the item being
  # made or with the reason why it cannot be made
  #-----------------------------------------------------------------------------
  def update_help
    recipe = @data[self.index]
    if @item_max < 1
      @help_window.set_text("You have not discovered any recipes yet!")
    else
      if recipe == nil
        categoryText = @categoryText[@categoryIndices.index(self.index)]
        @help_window.set_text(categoryText)
      else
        if recipe.isCraftable?
          descriptionText = recipe.itemCreated.description
          @help_window.set_text(recipe == nil ? "" : descriptionText)
        else
          @help_window.set_text(recipe == nil ? "" : recipe.disabledReason)
        end
      end
    end
  end
  
  def dispose
    super
    $game_crafting.categoryStates = @showCategory if @rememberCategoryStates
  end
  
end

I know the creator of this script no longer supports it.. but I have yet to find a great crafting script for VX that even comes close. If anyone could help, I would sure appreciate it

[Night5h4d3]

Im on a mobile device, so I can't offer any 'in depth' support tight now, but my guess would be that it's a conflicting script. If that's the case (and im fairly certain it is) it might be your quicksave/load/delete OR your fullscreen toggle option. Try disabling these (one at a time) and see if it works.

If not, start disabling one script at a time (but all of the multi-scripts such as takentai) until it stops giving the error, and that script wi be the incompatible one. Post it, and maye someone will be able to make it compatable.

[Aedales]

You could be right.. the only change I got though, was removing the Full Screen Toggle... which game me a new error:



Line 190 reads:

CODE

     @ingredients_window.set_tools(@categoryIndices.index(self.index))

[Night5h4d3]

Seems like further incompatibility, try going through the script disabling method again, keep the scripts you've already disabled that way, and I'd suggest starting by disabling the menu scripts, though that may not be it.

Edit- it's about 2AM where I am, so once you get it to where you get no errors, keep the scripts disabled, and I suggest that you upload your project so that I, or someone else can make the necessary comatability updates.

[Aedales]

Unfortunatly.. no go. I pulled out everything but my combat and my mouse input scripts and still the exact same error as the last one I posted