Shopoholic v 2.0, Advanced Shopping features (v 2.0 Since June 25) Options

[cmpsr2000]

Oh thanks a million cmpsr2000. You really went all out on the update.

You have no idea ;.; Took me twice as long as I was planning lol

A nice bonus of selling skills, classes, and actors(that almost seems wrong).

Everyone needs a slave now and then

Actually I added that so people could build a "mercenary" system easily.

[The Wizard 007]

Yeah the hireling/mercenary system will be great for a side project I am somewhat working on. After a little more playing around I found a couple bugs. In the nomal shop if I try purchasing the first item no mater what it is it brings up a line 393 NoMethodError, undefined method '>' for false:FalseClass, tried tweaking the symbols a little, didn't work, then tried deleting lines 392-397 it worked then but I'm not sure if it will affect anything eventually.

I found the second bug when I changed the shop menu a little and started buying some equipment for some reason it doesn't add the item to the inventory, it will make the sound like it is being bought then I noticed the possession number stayed 0 and went to check my items and there was nothing added.

I then made sure to test both of these bugs again on your new demo without any modifications and sure enough they are still there, the NoMethod Error and the shopkeeper who steals your money bug (pretty comical twist actually).
I hope these bugs are easily fixable. I know you've been working hard on it and have other scripts on your plate to deal with.

And as far as adding features the script has awesome features already but maybe have an option to show hit rate, evasion, and critical +'s and -'s, it looks like there would be room to do so in the right hand shop menu. And maybe a feature that shows the actual + or - for each weapon/armor stat instead of the total atk/def/etc. that the actor would have after equipping the item. Something like...

Atk +3 Spi -1
Def +4 Agi +0

Hope you can consider these features but it's not really necessary. ANyway good luck and thanks.

This post has been edited by The Wizard 007: Jun 3 2008, 03:24 PM

[cmpsr2000]

Yeah the hireling/mercenary system will be great for a side project I am somewhat working on. After a little more playing around I found a couple bugs. In the nomal shop if I try purchasing the first item no mater what it is it brings up a line 393 NoMethodError, undefined method '>' for false:FalseClass, tried tweaking the symbols a little, didn't work, then tried deleting lines 392-397 it worked then but I'm not sure if it will affect anything eventually.

I found the second bug when I changed the shop menu a little and started buying some equipment for some reason it doesn't add the item to the inventory, it will make the sound like it is being bought then I noticed the possession number stayed 0 and went to check my items and there was nothing added.

I then made sure to test both of these bugs again on your new demo without any modifications and sure enough they are still there, the NoMethod Error and the shopkeeper who steals your money bug (pretty comical twist actually).
I hope these bugs are easily fixable. I know you've been working hard on it and have other scripts on your plate to deal with.

And as far as adding features the script has awesome features already but maybe have an option to show hit rate, evasion, and critical +'s and -'s, it looks like there would be room to do so in the right hand shop menu. And maybe a feature that shows the actual + or - for each weapon/armor stat instead of the total atk/def/etc. that the actor would have after equipping the item. Something like...

Atk +3
Def +4

Good idea, I'll add an option that will allow the developer to choose additive or strict modifier +/-.

I thought I had fixed all those "> false" errors >.< For some reason, the hash is returning the value of .eql? instead of evaluating it and returning the default "nil" value. I think I know what the equip problem is as well, those should be easy fixes...brb >.>

edit: Ok, fixed the bugs. The feature will be in the next big update.

v 1.01 changes:

• Fixed bug where the shopkeeper would steal your money and keep your equipment when buying
• Fixed crash when buying from a basic store.

[The Wizard 007]

Great work man, works like a charm. Thanks for responding so quickly. I Look forward to the next update.

[Guest_From_Ariel_*]

You need to move shopaholic.zip to demo the demo link is broken

[cmpsr2000]

You need to move shopaholic.zip to demo the demo link is broken

ah I forgot to update the postIDs after I changed out the files, good catch!

[cmpsr2000]

New in v 1.02:

• Updated compatibility with other scripts. Saving and object instantiation should now happen unless another script is placed AFTER Shopoholic that redefines those methods without first aliasing and executing the alias.

[sargunster]

ur an amazing scripter!!!!

[cmpsr2000]

ur an amazing scripter!!!!

lol thanks!

[Devlin]

Fantastic script! I really love your shopoholic script. It's so useful and I can think of many different ways to use them, such as day/night shops, depending on relationships between shopkeeper and player, they can mark down the price or up, and so forth. It I'll be keeping my eye on this script.

EDIT: Okay, I ran into an odd error. I thought it might be same SHOPID I used so I changed it to 2. And I still run into the problems if I have money. I go into the shop if I don't have any gold and it works fine. But soon as I get money, and open the shop again, it crashed. It was weird because my first shopping event works prefectly but my second shopping event is not.

[Show/Hide] Picture

You can see how I set up the call script, and ran into the error soon as I talked to the shopping event. Also you can see the picture at bottom, I was able to open up the shopping menu only if I have no gold. I'm not sure if this information is useful to you but I have only one person in the party, nobody else.

EDIT2:
I found out the cause of the problem. It is "purchase only" option. I checked it because I didn't want the player to sell anything to the shop. With the option checked, I run into the errors. If I unchecked it, works fine.

This post has been edited by Devlin: Jun 14 2008, 08:39 PM

[cmpsr2000]

EDIT: Okay, I ran into an odd error. I thought it might be same SHOPID I used so I changed it to 2. And I still run into the problems if I have money. I go into the shop if I don't have any gold and it works fine. But soon as I get money, and open the shop again, it crashed. It was weird because my first shopping event works prefectly but my second shopping event is not.

EDIT2:
I found out the cause of the problem. It is "purchase only" option. I checked it because I didn't want the player to sell anything to the shop. With the option checked, I run into the errors. If I unchecked it, works fine.

hmm that's odd, I'll take a look at it. is your first shopping event a basic shop as well?

[Devlin]

EDIT: Okay, I ran into an odd error. I thought it might be same SHOPID I used so I changed it to 2. And I still run into the problems if I have money. I go into the shop if I don't have any gold and it works fine. But soon as I get money, and open the shop again, it crashed. It was weird because my first shopping event works prefectly but my second shopping event is not.

EDIT2:
I found out the cause of the problem. It is "purchase only" option. I checked it because I didn't want the player to sell anything to the shop. With the option checked, I run into the errors. If I unchecked it, works fine.

hmm that's odd, I'll take a look at it. is your first shopping event a basic shop as well?

Yes, it's also a basic shop. But the purchase only option was not checked. That is why my first shopping event worked fine.

EDIT: I went back to test it. I set my first shopping event to "purchase only", and yep. I ran into same error.

This post has been edited by Devlin: Jun 14 2008, 08:58 PM

[cmpsr2000]

Yes, it's also a basic shop. But the purchase only option was not checked. That is why my first shopping event worked fine.

EDIT: I went back to test it. I set my first shopping event to "purchase only", and yep. I ran into same error.

Ok, that should be easily fixable. I'm working on a new version of this right now anyhow.

[Devlin]

Ok, that should be easily fixable. I'm working on a new version of this right now anyhow.

Okay. I will be looking forward at your new version. Thank you for your script.

[Stress]

This is insane!

Haha. Nice!

Thanks! I don't have many shops in my game but when I do...they'll be AWESOME!!!

Haha! Actually the best part of this is the cha ching sound effect included. That's gold.

EDIT: /facepalm...

SE is standard RPGM VX...

Heh. You learn something new everyday!!!

This post has been edited by Stress: Jun 15 2008, 01:55 AM

[spike_xp]

may i request a feature? a feature that makes floating prices. if the stock's low, then make the price will grow higher. vice versa.

thx for your attention...

[cmpsr2000]

may i request a feature? a feature that makes floating prices. if the stock's low, then make the price will grow higher. vice versa.

thx for your attention...

That's a good idea, I'll add it into the upcoming version!

[Aindra]

Great script.

My suggestion that you go add your credit/version into the script as the comments. Because there are no version listed in the script, I wasn't sure if I'm using 1.0 version or 1.02 version. The demo says something like "Welcome to Shopolic 1.0!" so that got me all confused.

[cmpsr2000]

Great script.

My suggestion that you go add your credit/version into the script as the comments. Because there are no version listed in the script, I wasn't sure if I'm using 1.0 version or 1.02 version. The demo says something like "Welcome to Shopolic 1.0!" so that got me all confused.

Ah ok, I was kinda lazy on the commenting for awhile but I've been adding this info in with my newest versions. I'll make sure it's there with the next version!

[Aindra]

That's good.

If you don't mind another suggestion for your script...

Player can only sell weapons to weaponsmith, armours to armoursmith, etc. Is it possible?